Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Standardise issuer and verify send/accept endpoint convention #623

Open
ff137 opened this issue Jan 16, 2024 · 0 comments
Open

🎨 Standardise issuer and verify send/accept endpoint convention #623

ff137 opened this issue Jan 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ff137
Copy link
Collaborator

ff137 commented Jan 16, 2024

Extending from #226:

issuer uses POST /generic/issuer/credentials for send offer and /generic/issuer/credentials/{credential_id}/request for send request
verifier uses POST /generic/verifier/send-request and /generic/verifier/accept-request with the proof id in the body.

It's a sound recommendation that these endpoints should follow a unified convention.

I recommend that the issuer endpoints should be more like the verifier routes:

  • POST /generic/issuer/credentials -> /generic/issuer/credentials/send-credential or /generic/issuer/send-credential
  • POST /generic/issuer/credentials/{credential_id}/request -> /generic/issuer/credentials/accept-credential
@ff137 ff137 added the enhancement New feature or request label Jan 16, 2024
@ff137 ff137 changed the title Standardise issuer and verify send/accept endpoint convention 🎨 Standardise issuer and verify send/accept endpoint convention Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant