Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdl-selectfield is too slow, cannot use disabled options #24

Open
SergeiStruk opened this issue Mar 15, 2016 · 7 comments
Open

mdl-selectfield is too slow, cannot use disabled options #24

SergeiStruk opened this issue Mar 15, 2016 · 7 comments
Assignees

Comments

@SergeiStruk
Copy link

mdl-selectfield works too slow, also I didn't find a way to use disabled select options.

@dgrubelic
Copy link
Owner

Thank you for your testing :)
Can you provide a little bit more context of your testing? How many selectfield elements you had on page? In what way do you find it slow? Do you have some concrete numbers of it's just "slow" feeling?

Disabled feature can be used in three different ways (you can find two of them in /src/selectfield/demo.html):

  1. Using API (also used internally)
  2. Using is-disabled class on mdl-selectfield element
  3. disabled attribute on select element.

@SergeiStruk
Copy link
Author

I had 8 selectfield elements on the page.
I tried to use |disabled| attribute, but it didn't work, I'll test demo,
thanks.

The main problem is too slow work. Currently I'm trying to use this
plugin for selectfield:
https://github.com/MEYVN-digital/mdl-selectfield. It works much faster,
but it has problems with loading new options via AJAX.
So, I decided to try your solution.

On 03/15/2016 09:43 PM, Davor Grubelić wrote:

Thank you for your testing :)
Can you provide a little bit more context of your testing? How many
selectfield elements you had on page?

Disabled feature can be used in three different ways (you can find two
of them in |/src/selectfield/demo.html|):

  1. Using API (also used internally)
  2. Using |is-disabled| class on |mdl-selectfield| element
  3. |disabled| attribute on select element.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#24 (comment)

Best regards,
Sergei

@dgrubelic
Copy link
Owner

That's the purpose of testing. To polish the component :)

That's funny, because there is a "disabled" demo in demo.html and that demo is working fine. However, i just discovered some issue with IE10 so that might be the reason. I'm on it right now.

The reason why this component might be little bit slower is due to logic that this component supports. Since i'm trying to build component that doesn't kill accessibility which is supported in select element and is mentioned in google#854 issue.
The component you mentioned doesn't support tabIndex focus (important for form element navigation using tab key) and full keyboard navigation (expect up and down keys)

@SergeiStruk
Copy link
Author

Got it, thanks for clarification! Please, let me know when you fix issues :)

On 03/15/2016 10:10 PM, Davor Grubelić wrote:

That's the purpose of testing. To polish the component :)

That's funny, because there is a "disabled" demo in demo.html and that
demo is working fine. However, i just discovered some issue with IE10
so that might be the reason. I'm on it right now.

The reason why this component might be little bit slower is due to
logic that this component supports. Since i'm trying to build
component that doesn't kill accessibility which is supported in select
element and is mentioned in google#854
google#854 issue.
The component you mentioned doesn't support tabIndex focus (important
for form element navigation using tab key) and full keyboard
navigation (expect up and down keys)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#24 (comment)

Best regards,
Sergei

@dgrubelic
Copy link
Owner

Will do. Again, thank you for taking time to test the component. :)

@dgrubelic
Copy link
Owner

@SergeiStruk IE10 issues are fixed. Can you please tell me what environment are you using for testing? OS, browser version, etc...

@SergeiStruk
Copy link
Author

Ubuntu 14.04, Chrome 48.0.2564.116 (64-bit)

Thanks!

On 03/15/2016 11:11 PM, Davor Grubelić wrote:

@SergeiStruk https://github.com/SergeiStruk IE10 issues are fixed.
Can you please tell me what environment are you using for testing? OS,
browser version, etc...


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#24 (comment)

Best regards,
Sergei

@dgrubelic dgrubelic self-assigned this Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants