Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition a chunk with a tag #27

Open
k0pernicus opened this issue Jan 21, 2017 · 1 comment
Open

Condition a chunk with a tag #27

k0pernicus opened this issue Jan 21, 2017 · 1 comment

Comments

@k0pernicus
Copy link
Contributor

k0pernicus commented Jan 21, 2017

A good observation from slamb in the Reddit post announcement is:

It looks like your chunk GET requests are not conditioned on an etag, or even on a Last-Modified header.
So if the server doesn't serve the same file every time (such as if the file were replaced on the server
halfway through), you'll blindly put together parts of different files without any warning.
This checking shouldn't be hard to add; I think it'd be better to do it and warn the user in this case.

I agree with this comment, and I think we should warn the user as a first case, and implement a better solution for a next release.

@Jean-Serge
Copy link
Collaborator

Yes but it seems this issue depends on the #32 one. If we do not implement the behaviour for interrupting download, it has no sense to use e-tag.

What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants