Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBIX Freezes #514

Open
Nish0234 opened this issue Oct 24, 2024 · 2 comments
Open

PBIX Freezes #514

Nish0234 opened this issue Oct 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Nish0234
Copy link

Nish0234 commented Oct 24, 2024

Hello,

Since last few days I am facing an issue of the PBIX that I am working on freezes and have to forcefully close the file. This happens only when I copy and paste below code in config.

{
  "width": "container",
  "height": "container",
  "autosize": {
    "type": "fit",
    "contains": "padding",
    "resize": true
  },
  "view": {"stroke": "transparent"},
  "font": "Segoe UI",
  "arc": {},
  "area": {},
  "bar": {},
  "line": { },
  "path": {},
  "point": {"filled": true, "size": 75},
  "rect": {},
  "shape": {},
  "symbol": { },
  "tick": {"width": 60, "height": 5, 
      "thickness": 5,
      "bandSize": 20
    },
  "text": {
          "font": "Segoe UI",
           "fontSize": 12,
          "fontWeight": "bold"  },
  
  "axis": {
    "ticks": false,
    "grid": false,
    "domain": false,
    "labelFlush": false,
    "labelColor": "black",
    "labelFontWeight": "bold",
    "labelFontSize": 13,
    "titleFont": "wf_standard-font, helvetica, arial, sans-serif",
    "titleColor": "black",
    "titleFontSize": 16,
    "titleFontWeight": "bold"
  },
  
   "axisQuantitative": {
     "tickCount": 5,
    "grid": false,
    "gridDash": [1, 5],
    "labelFlush": true
  },
  "axisX": {"labelPadding": 5,
            "labelAngle": 0 },
  "axisY": {"labelPadding": 5
  },
  "header": {
    "titleFont": "wf_standard-font, helvetica, arial, sans-serif",
    "titleFontSize": 16,
    "labelFont": "Segoe UI",
    "labelFontSize": 13.333333333333332,
    "labelColor": "#605E5C"
  },
  "legend": {
    "titleFont": "Segoe UI",
    "titleFontWeight": "bold",
    "labelFont": "Segoe UI",
    "labelFontSize": 13.333333333333332,
    "symbolType": "circle",
    "symbolSize": 75
  }
}
@dm-p dm-p added the bug Something isn't working label Oct 24, 2024
@dm-p
Copy link
Member

dm-p commented Oct 24, 2024

Hi, and thanks for raising. This is an odd problem, for sure. The part of your config causing the problem is this:

{
    "width": "container",
    "height": "container"
}

Deneb manages the height and width (with similar values if missing) when a spec change is applied, so they are unnecessary. However, this shouldn't break things for you and I will investigate and hopefully fix it.

For now as a workaround, you can paste the config without those offending values, e.g.:

{
    "autosize": {
        "type": "fit",
        "contains": "padding",
        "resize": true
    },
    "view": {
        "stroke": "transparent"
    },
    "font": "Segoe UI",
    "arc": {},
    "area": {},
    "bar": {},
    "line": {},
    "path": {},
    "point": {
        "filled": true,
        "size": 75
    },
    "rect": {},
    "shape": {},
    "symbol": {},
    "tick": {
        "width": 60,
        "height": 5,
        "thickness": 5,
        "bandSize": 20
    },
    "text": {
        "font": "Segoe UI",
        "fontSize": 12,
        "fontWeight": "bold"
    },
    "axis": {
        "ticks": false,
        "grid": false,
        "domain": false,
        "labelFlush": false,
        "labelColor": "black",
        "labelFontWeight": "bold",
        "labelFontSize": 13,
        "titleFont": "wf_standard-font, helvetica, arial, sans-serif",
        "titleColor": "black",
        "titleFontSize": 16,
        "titleFontWeight": "bold"
    },
    "axisQuantitative": {
        "tickCount": 5,
        "grid": false,
        "gridDash": [
            1,
            5
        ],
        "labelFlush": true
    },
    "axisX": {
        "labelPadding": 5,
        "labelAngle": 0
    },
    "axisY": {
        "labelPadding": 5
    },
    "header": {
        "titleFont": "wf_standard-font, helvetica, arial, sans-serif",
        "titleFontSize": 16,
        "labelFont": "Segoe UI",
        "labelFontSize": 13.333333333333332,
        "labelColor": "#605E5C"
    },
    "legend": {
        "titleFont": "Segoe UI",
        "titleFontWeight": "bold",
        "labelFont": "Segoe UI",
        "labelFontSize": 13.333333333333332,
        "symbolType": "circle",
        "symbolSize": 75
    }
}

Root cause (for my notes when I get time to address):

When the above values are supplied, they cause an infinite loop in the Vega renderer, which eventually causes the JS thread to hang. We get the following errors in the console (repeated until our session dies):

image

@dm-p dm-p self-assigned this Oct 24, 2024
@dm-p dm-p added this to the 1.7.3 milestone Oct 24, 2024
@Nish0234
Copy link
Author

Nish0234 commented Oct 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants