You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think there is unexpected behavior regarding subscriptions disposal.
If you deref reagent atom outside of reagent rendering context, dependent subscription are not updated inside a watching list of parent subscription. So when you dispose! it, dependent subs are not getting disposed.
Instead of using deref, should reagent.ratom/run be used which properly updates ratom watching list.
Here is the code snippet which demonstrates the issue:
Hi @dmitryn, would you have a fix for that issue? Even if the project does not appear to be maintained, its users would be very happy to get access to a PR.
Hello 👋
I think there is unexpected behavior regarding subscriptions disposal.
If you deref reagent atom outside of reagent rendering context, dependent subscription are not updated inside a watching list of parent subscription. So when you
dispose!
it, dependent subs are not getting disposed.Instead of using deref, should reagent.ratom/run be used which properly updates ratom watching list.
Here is the code snippet which demonstrates the issue:
I could make a PR if you think this is a good idea.
I also raised this question in clojurians slack, but didn't get any response.
The text was updated successfully, but these errors were encountered: