Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/remove chats to widgets from chat-details #2452

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zeitschlag
Copy link
Collaborator

Simulator Screenshot - iPhone 16 Pro - 2024-12-21 at 20 06 35

@zeitschlag zeitschlag requested a review from r10s December 21, 2024 19:06
Base automatically changed from 2449-access-chats-from-widget to main December 21, 2024 19:07
@zeitschlag zeitschlag force-pushed the add-chats-to-widgets-another-way branch from 90f0736 to 8ee5160 Compare December 21, 2024 19:08
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for contact profiles having a one-to-one chat, but in case there is no chat, the option must not be added, see comment below

for group profiles, the option is still missing

(we have that code duplicated for $reasons on iOS, probably came out some "c'mon, it is just a handful lines" :)

deltachat-ios/ViewModel/ContactDetailViewModel.swift Outdated Show resolved Hide resolved
@zeitschlag zeitschlag linked an issue Dec 22, 2024 that may be closed by this pull request
@zeitschlag zeitschlag force-pushed the add-chats-to-widgets-another-way branch from 8ee5160 to c406bba Compare December 22, 2024 10:41
@zeitschlag zeitschlag requested a review from r10s December 22, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add option to add/remove chats to/from widget to profiles
2 participants