From 6231e6ae62fd7b24433c987852eaedbaa141c11a Mon Sep 17 00:00:00 2001 From: zorzal Date: Tue, 10 Dec 2024 13:00:46 -0500 Subject: [PATCH] fix: change mapping variable names in favor of clarity --- solidity/contracts/Oracle.sol | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/solidity/contracts/Oracle.sol b/solidity/contracts/Oracle.sol index 9283cb9..cb89791 100644 --- a/solidity/contracts/Oracle.sol +++ b/solidity/contracts/Oracle.sol @@ -20,13 +20,13 @@ contract Oracle is IOracle, OracleAccessController { mapping(bytes32 _requestId => uint256 _finalizedAt) public finalizedAt; /// @inheritdoc IOracle - mapping(bytes32 _id => uint256 _requestCreatedAt) public requestCreatedAt; + mapping(bytes32 _requestId => uint256 _requestCreatedAt) public requestCreatedAt; /// @inheritdoc IOracle - mapping(bytes32 _id => uint256 _responseCreatedAt) public responseCreatedAt; + mapping(bytes32 _responseId => uint256 _responseCreatedAt) public responseCreatedAt; /// @inheritdoc IOracle - mapping(bytes32 _id => uint256 _disputeCreatedAt) public disputeCreatedAt; + mapping(bytes32 _disputeId => uint256 _disputeCreatedAt) public disputeCreatedAt; /// @inheritdoc IOracle mapping(bytes32 _responseId => bytes32 _disputeId) public disputeOf; @@ -35,7 +35,7 @@ contract Oracle is IOracle, OracleAccessController { mapping(bytes32 _disputeId => DisputeStatus _status) public disputeStatus; /// @inheritdoc IOracle - mapping(uint256 _requestNumber => bytes32 _id) public nonceToRequestId; + mapping(uint256 _nonce => bytes32 _requestId) public nonceToRequestId; /// @inheritdoc IOracle mapping(bytes32 _requestId => bytes32 _finalizedResponseId) public finalizedResponseId; @@ -111,6 +111,7 @@ contract Oracle is IOracle, OracleAccessController { AccessControl[] calldata _accessControl ) external returns (bytes32[] memory _batchRequestsIds) { uint256 _requestsAmount = _requestsData.length; + _batchRequestsIds = new bytes32[](_requestsAmount); for (uint256 _i; _i < _requestsAmount;) {