Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] to support multiple versions of cp2k #326

Closed
HuangJiameng opened this issue Jul 6, 2022 · 9 comments
Closed

[Feature Request] to support multiple versions of cp2k #326

HuangJiameng opened this issue Jul 6, 2022 · 9 comments
Labels
cp2k enhancement New feature or request

Comments

@HuangJiameng
Copy link
Collaborator

Summary

to support multiple versions of cp2k

Detailed Description

https://github.com/deepmodeling/dpdata/discussions/323
For popular versions of cp2k, related output.py are demanded.

@HuangJiameng HuangJiameng added the enhancement New feature or request label Jul 6, 2022
@HuangJiameng
Copy link
Collaborator Author

@robinzyb Just a kindly reminder, what is the progress of supporting CP2K versions 8.1 and 9.1?

@robinzyb
Copy link
Collaborator

robinzyb commented Nov 12, 2022

@robinzyb Just a kindly reminder, what is the progress of supporting CP2K versions 8.1 and 9.1?

see here. I have written a new plugin for dpdata.
https://github.com/robinzyb/cp2kdata
Plug-in for dpdata

support version include 6.1 7.1 8.1 and 9.0.

@wanghan-iapcm
Copy link
Contributor

What is the best way of officially support cp2kdata in dpdata ? @HuangJiameng @njzjz

@njzjz
Copy link
Member

njzjz commented Nov 14, 2022

What is the best way of officially support cp2kdata in dpdata ?

It's fine to add it to the dependencies or optional dependencies, depending on what you want it to be.

@wanghan-iapcm
Copy link
Contributor

cp2kdata depends on dpdata, it would introduce a cyclic dependency

@HuangJiameng
Copy link
Collaborator Author

I haven't figured out why cp2kdata can support cp2k v8.1/9.1 yet, since I only find unit test for v6.1/7.1 in https://github.com/robinzyb/cp2kdata/tree/devel/tests/test_dpdata @robinzyb

@robinzyb
Copy link
Collaborator

you can find all versions under this directory cp2kdata/tests/test_energy_force/. Files in test_dpdata are the files copied from original dpdata repository to test compatibility. It would be great If anyone can provide cp2k outputs with different versions as my test files.

@njzjz
Copy link
Member

njzjz commented Nov 19, 2022

It's fine to throw an error when the cp2k version is not supported.

if version > supported_version:
    raise RuntimeError(
        "This CP2k version is not supported. Try the dpdata plugin from "
        "https://github.com/robinzyb/cp2kdata"
    )

@njzjz njzjz added the cp2k label Nov 5, 2023
@robinzyb
Copy link
Collaborator

Multiple versions and comprehensive tests are done by cp2kdata.
and the deprecation warning was added #558

Is there anything else to do to resolve this issue?

@robinzyb robinzyb closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp2k enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants