-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] to support multiple versions of cp2k #326
Comments
@robinzyb Just a kindly reminder, what is the progress of supporting CP2K versions 8.1 and 9.1? |
see here. I have written a new plugin for dpdata. support version include 6.1 7.1 8.1 and 9.0. |
What is the best way of officially support cp2kdata in dpdata ? @HuangJiameng @njzjz |
It's fine to add it to the dependencies or optional dependencies, depending on what you want it to be. |
cp2kdata depends on dpdata, it would introduce a cyclic dependency |
I haven't figured out why cp2kdata can support cp2k v8.1/9.1 yet, since I only find unit test for v6.1/7.1 in https://github.com/robinzyb/cp2kdata/tree/devel/tests/test_dpdata @robinzyb |
It's fine to throw an error when the cp2k version is not supported. if version > supported_version:
raise RuntimeError(
"This CP2k version is not supported. Try the dpdata plugin from "
"https://github.com/robinzyb/cp2kdata"
) |
Multiple versions and comprehensive tests are done by Is there anything else to do to resolve this issue? |
Summary
to support multiple versions of cp2k
Detailed Description
https://github.com/deepmodeling/dpdata/discussions/323
For popular versions of cp2k, related output.py are demanded.
The text was updated successfully, but these errors were encountered: