Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate excludes when browsing for files / using the Explorer view #1216

Open
Terrance opened this issue Oct 3, 2024 · 5 comments
Open
Labels
P2 random bugs & feature requests page:explorer type:feature New feature or request

Comments

@Terrance
Copy link

Terrance commented Oct 3, 2024

Is your feature request related to a problem? Please describe.

I currently use Aves as my image selection intent handler (my file manager app doesn't provide one; the only other provider is an image editor), which works fine for most uses. However, I like to have various "noisy" folders hidden (e.g. downloads) but occasionally need to select images from them.

Describe the solution you'd like

A few possibilities come to mind:

  • manage excludes separately between the Explorer view and the rest of the app
  • manage excludes separately between the image selection intent and regular usage
  • add a menu option to temporarily show hidden albums

The Explorer view feels like a reasonable place to show all albums (perhaps with some indication / greying out of albums normally hidden in other views), but any of the above would work for me.

Describe alternatives you've considered

Currently I've just unhidden things, but it makes the Albums view rather cluttered (e.g. one of the folders I would normally have hidden but occasionally need to select from is organised into various subfolders, which all appears as their own albums mixed in with real albums I want to use more day-to-day) -- #538 would help with that.

Additional context

I'm aware Aves is not a file manager, but the intent handler is there and (for me at least) I tend to need/want different subsets of my media library when browsing in the gallery vs. selecting media for a different app.

@Terrance Terrance added the type:feature New feature or request label Oct 3, 2024
@deckerst
Copy link
Owner

deckerst commented Oct 3, 2024

The Explorer view feels like a reasonable place to show all albums (perhaps with some indication / greying out of albums normally hidden in other views), but any of the above would work for me.

This suggestion is interesting, as showing additional folders here do not significantly clutter the view the same as it does elsewhere. However, let's say you open a folder via the explorer that way, then you get to select items in the Collection page, and this becomes tricky to decide what to show here. Hiding allows much more fine-grained filtering than simply hiding a folder.

Same goes for the exclusion segregation suggestion, because eventually users will be back on the Collection page to actually select items.

I believe that it's easy enough to toggle hidden filters and paths on and off as needed via the Settings > Privacy > Hidden items.1 Have you considered using these toggles when you actually need to browse hidden items?

Footnotes

  1. I've just realized that hidden filters can be toggled but not hidden paths! I should make those the same way...

@deckerst
Copy link
Owner

deckerst commented Oct 3, 2024

I've just realized that hidden filters can be toggled but not hidden paths! I should make those the same way...

Done. And hidden path filters are now listed with the others, so it's one tap less to reach and toggle them.

@Terrance
Copy link
Author

Terrance commented Oct 3, 2024

toggle hidden filters and paths on and off as needed

I hadn't realised these were toggleable once added to the list -- that would probably do, though it's a little clunky:

  • trigger an image selection intent from X, opening Aves
  • dig into Aves' settings to untick the album I need
  • pick a file from that album, returning to X
  • ...
  • come back to Aves and hide that album again (realistically this will probably end up being some time later after forgetting and later noticing it lurking in the album list)

Filters wouldn't work well for my hierarchical folders as I'd have to keep ignoring new subfolders, though with the above fix I could just exclude the root as a path and toggle that as needed.

let's say you open a folder via the explorer that way, then you get to select items in the Collection page, and this becomes tricky to decide what to show here

If you choose a "leaf" folder (i.e. one with no children) from Explorer that would otherwise be hidden, we can just show its contents.

It looks like selecting a folder with children (i.e. one with the hierarchy icon) already works differently here vs. selecting the corresponding album: the former includes subfolders, the latter does not. I'd therefore be inclined to allow it to display all files and ignore hidden filters in this case too. If that search selection is removed, the normal hidden filters apply again.

@deckerst
Copy link
Owner

deckerst commented Oct 4, 2024

If you choose a "leaf" folder (i.e. one with no children) from Explorer that would otherwise be hidden, we can just show its contents.

Let's say you don't like seeing videos in Aves, so you hide them. You also hide a folder but you want to see that folder the way you suggest. When getting visible, I'm sure you expect to see the contents of that folder without the videos. That's what I meant by fine-grained filtering. Items can be hidden in many ways, by path, type, location, tags, and combinations of these.

Anyway, I have an idea that would solve your problem, be transparent to users who do not need it, and do not require segregation or lengthy explanation. It's a combination of 1) your suggestion regarding showing in the explorer paths with hidden content, 2) detection in the Collection page of empty content and matching hidden filters, adding ad hoc toggles right there (these toggles would be for the session only).

@Terrance
Copy link
Author

Terrance commented Oct 4, 2024

Items can be hidden in many ways, by path, type, location, tags, and combinations of these.

I suspect my perception is somewhat skewed by the "typical" gallery app design, which tends to treat hiding folders (and which tends to come with a temporary "show hidden folders" button) and filtering the current view (by date, type, or whatever else) as two largely separate features.

Here, everything is a filter in a unified search, which is powerful but indeed leads to the ambiguity you're describing when they're combined. I was imagining the combination of a) hidden paths not applying in the Explorer view, and b) hidden paths not applying to an album/path search filter (that is, if you explicitly choose a path, it overrules hidden paths). Any other searches/filters would apply as normal on top of that, and the albums would be hidden outside of the Explorer view so (in theory) you wouldn't be able to select one in the first place.

It's a combination of 1) your suggestion regarding showing in the explorer paths with hidden content, 2) detection in the Collection page of empty content and matching hidden filters, adding ad hoc toggles right there (these toggles would be for the session only).

In any case, this sounds like it will work too, so I will wait and see what it looks like. 🙂

@deckerst deckerst added P2 random bugs & feature requests page:explorer labels Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 random bugs & feature requests page:explorer type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants