Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to always lock vault-folder when closed #1136

Open
FedericoGnesotto opened this issue Aug 17, 2024 · 6 comments
Open

Add option to always lock vault-folder when closed #1136

FedericoGnesotto opened this issue Aug 17, 2024 · 6 comments
Labels
P3 valid issue to be addressed in the future type:feature New feature or request vaults

Comments

@FedericoGnesotto
Copy link

Currently, a vault folder gets locked only by manually doing so via the three dots on top right after long press on album thumbnail (could be easier too) and (optional) when the screen turns off. It would be useful to have an option to always lock when the folder is not open.
Thanks a lot and keep up the great work!

@FedericoGnesotto FedericoGnesotto added the type:feature New feature or request label Aug 17, 2024
@deckerst
Copy link
Owner

(optional) when the screen turns off

How is it optional? Isn't it doing it every time?

As for your request, I'm unlikely to do it because there is no concept of "closing" an album in Aves. For example, when you go from the Collection page to the map, is that closing the album? Or to the map then the viewer? Or map > viewer > info > applying a filter? Etc.

@deckerst
Copy link
Owner

Edit: sorry, I forgot there was an actual option for it in the vault settings ^^

@FedericoGnesotto
Copy link
Author

Hi, yes I would say so. If the Album or an image inside it is not currently focused (being viewed), then it should be locked. Would that be possible?

@deckerst
Copy link
Owner

Maybe, I'll need to think about it.

@FedericoGnesotto
Copy link
Author

I am happy to contribute the feature myself, but I would need some guidance as I am not a mobile dev (C++ desktop mainly). Anyways thanks for the great app!

@deckerst
Copy link
Owner

No worries. This repo doesn't accept PRs anyway.

@deckerst deckerst added P3 valid issue to be addressed in the future vaults labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 valid issue to be addressed in the future type:feature New feature or request vaults
Projects
None yet
Development

No branches or pull requests

2 participants