Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables Figma vs Variables Code #3464

Open
2 of 7 tasks
StefanSeliger opened this issue Nov 14, 2024 · 4 comments
Open
2 of 7 tasks

Variables Figma vs Variables Code #3464

StefanSeliger opened this issue Nov 14, 2024 · 4 comments
Labels

Comments

@StefanSeliger
Copy link

StefanSeliger commented Nov 14, 2024

Which generators are impacted?

  • All
  • HTML
  • React
  • Angular
  • Vue
  • Web components
  • Power Apps

Reproduction case

I got a ux/ui design in figma from our ux designer. It contained variables for font size, border, colors etc. Unfortunately the variables she is using are not the same as in the code (auto complete). The tokens differ. The order is different to be precise.

Also I find it almost impossible to find variables like colors. There is no list that includes all variables.

Expected Behaviour

The tokens she is using should be same as in the code. figma and code should be synced.

I'd also expect a simple overview, a list, with all variables available and all colors included.

Screenshots

Bildschirmfoto 2024-11-14 um 16 11 49
Bildschirmfoto 2024-11-14 um 16 13 45

Browser version

Chrome

Add any other context about the problem here.

No response

@StefanSeliger
Copy link
Author

I just realized that we changed the variables from xs to md, but you can see that the order is still different. First screenshot is figma, second is from my editor (VSCode). The actual size is at the end.

@mfranzke mfranzke added the 👩‍👧‍👦community feedback Feedback from community label Nov 14, 2024
@nmerget
Copy link
Member

nmerget commented Nov 14, 2024

@StefanSeliger thanks for your issue.

I thought the problem with the order was fixed in Figma. We gonna look into this.

Lately, we found some solution for the problem with the autocomplete. It's not the very best, but it a good starting point. We will officially announce this in v0.6.0 but you can use it right now as well: https://db-ui.github.io/mono/review/main/foundations/ide

@mfranzke
Copy link
Member

@StefanSeliger thanks for your issue.

I thought the problem with the order was fixed in Figma. We gonna look into this.

Lately, we found some solution for the problem with the autocomplete. It's not the very best, but it a good starting point. We will officially announce this in v0.6.0 but you can use it right now as well: https://db-ui.github.io/mono/review/main/foundations/ide

Additionally we're currently trying different approaches for an easier traceability in between figma and the code.

@mfranzke mfranzke changed the title Variables Figma vs Varibales Code Variables Figma vs Variables Code Nov 14, 2024
@mfranzke
Copy link
Member

@StefanSeliger thanks for your issue.
I thought the problem with the order was fixed in Figma. We gonna look into this.
Lately, we found some solution for the problem with the autocomplete. It's not the very best, but it a good starting point. We will officially announce this in v0.6.0 but you can use it right now as well: https://db-ui.github.io/mono/review/main/foundations/ide

Additionally we're currently trying different approaches for an easier traceability in between figma and the code.

this actually resulted in the following two PRs, which should have cleaned up remaining inconsistencies:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants