Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nameConfigs folder does not exist #1

Open
jurf opened this issue Nov 10, 2023 · 1 comment · Fixed by #2
Open

nameConfigs folder does not exist #1

jurf opened this issue Nov 10, 2023 · 1 comment · Fixed by #2
Assignees
Labels
bug Something isn't working

Comments

@jurf
Copy link

jurf commented Nov 10, 2023

Hey, thanks for this project!

When trying it out, I got an error on this line: https://github.com/daw1012345/vscode-for-toolbox/blob/main/bin/code#L25

The nameConfigs directory did not exist for me, so I had to create it by hand.

Misusing this issue, I think it might be worth a mention this method will not work on existing containers – that took me a while to figure out.

@daw1012345 daw1012345 self-assigned this Nov 10, 2023
@daw1012345 daw1012345 added the bug Something isn't working label Nov 10, 2023
daw1012345 added a commit that referenced this issue Nov 11, 2023
Fixes #1

The nameConfigs directory of the remote-containers VSCode extension can sometimes be missing. Create it during installation.
@daw1012345
Copy link
Owner

Thanks for your bug report! To address all the issues one by one:

When trying it out, I got an error on this line: https://github.com/daw1012345/vscode-for-toolbox/blob/main/bin/code#L25

I have addressed this with #2. The installation script will now create that directory if it is missing.

I think it might be worth a mention this method will not work on existing containers – that took me a while to figure out.

The project actually supported existing containers before 944a9db. However, the process was annoying (a command had to be manually ran on the host every time the container restarted). It is also possible to reconcile the current approach with the old one to support the convenient workaround for new containers, but revert to the old one if it's an existing container. Either way, I will make a note of this in the README.

@daw1012345 daw1012345 reopened this Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants