Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially confusing information about processes in the docs #635

Open
Andrew-S-Rosen opened this issue Mar 7, 2024 · 3 comments · May be fixed by #673
Open

Potentially confusing information about processes in the docs #635

Andrew-S-Rosen opened this issue Mar 7, 2024 · 3 comments · May be fixed by #673

Comments

@Andrew-S-Rosen
Copy link
Contributor

The docs state

By default Dask will run one Python process per job

However, the docstring for processes says by default it is sqrt(cores). I suppose if cores is 1, the first statement is indeed true, but it can give a false impression.
@Andrew-S-Rosen Andrew-S-Rosen changed the title Conflicting information about processes Potentially confusing information about processes in the docs Mar 7, 2024
@guillaumeeb
Copy link
Member

Once again you are right, documentation should be updated, since we rely on https://github.com/dask/distributed/blob/main/distributed/deploy/utils.py#L16 to compute the default number of processes.

@maneesh29s
Copy link

I was about to raise this same issue. It seems like a quick fix. Is anyone already working on this, or is it OK for me to raise a PR?

@Andrew-S-Rosen
Copy link
Contributor Author

Go ahead!

@maneesh29s maneesh29s linked a pull request Dec 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve process section in configure documentation maneesh29s/dask-jobqueue
3 participants
@Andrew-S-Rosen @guillaumeeb @maneesh29s