Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort commons by lastActivity in the dropdowns #2183

Closed
2 tasks done
elatif2020 opened this issue Oct 12, 2023 · 9 comments · Fixed by #2209 or #2310
Closed
2 tasks done

Sort commons by lastActivity in the dropdowns #2183

elatif2020 opened this issue Oct 12, 2023 · 9 comments · Fixed by #2209 or #2310
Assignees
Labels
Priority - B V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 12, 2023

  • In the breadcrumb dropdowns (below the active item)
  • In the navigation bar, in the dropdown

There should be a new index ready for this. See in the BE ticket:

          @elatif2020 I've added `lastActivity` to the common entity and FE should use it for sorting @andreymikhadyuk

Originally posted by @ariel-dao in https://github.com/daostack/common-backend/issues/2130#issuecomment-1759177479

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 Should we sort spaces as well in the navigation bar?

@andreymikhadyuk andreymikhadyuk linked a pull request Oct 17, 2023 that will close this issue
4 tasks
@elatif2020
Copy link
Collaborator Author

@elatif2020 Should we sort spaces as well in the navigation bar?

no

MeyerPV added a commit that referenced this issue Oct 20, 2023
Sort commons by lastActivity in the dropdowns #2183
@elatif2020
Copy link
Collaborator Author

As I understand currently it is sorted with the item with latest lastActivity at the bottom, it should be the opposite.

@elatif2020 elatif2020 reopened this Oct 22, 2023
@elatif2020
Copy link
Collaborator Author

@danielr18 maybe you can have an idea why my commons in staging are sorted upside down, while on dev, and for other users it is sorted correctly?

@andreymikhadyuk
Copy link
Collaborator

@danielr18 maybe you can have an idea why my commons in staging are sorted upside down, while on dev, and for other users it is sorted correctly?

do you have this issue in all your accounts?

@elatif2020
Copy link
Collaborator Author

@danielr18 maybe you can have an idea why my commons in staging are sorted upside down, while on dev, and for other users it is sorted correctly?

do you have this issue in all your accounts?

@andreymikhadyuk
yes in all my accounts, both in staging and in production
Actually now I was looking in dev and I'm not sure it is sorted correctly also there

@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk
As I understand now on dev some commons with recent activity move to the top of the list and some to the bottom

@NoamQA NoamQA added the V [production] verified on production enviroment label Oct 31, 2023
@andreymikhadyuk andreymikhadyuk removed the V [production] verified on production enviroment label Nov 13, 2023
andreymikhadyuk added a commit that referenced this issue Nov 13, 2023
Sort commons by lastActivity in the dropdowns - Fix commons sorting #2183
@NoamQA
Copy link
Collaborator

NoamQA commented Nov 14, 2023

@andreymikhadyuk @elatif2020

  • it is only sorted after i refresh
    in dev and in web stage
    when i move from inbox to feed or change common it also doesnt sort it...

Image

@NoamQA NoamQA reopened this Nov 14, 2023
@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk @elatif2020

* [x]  it is only sorted after i refresh
  in dev and in web stage
  when i move from inbox to feed or change common it also doesnt sort it...

Image

created a new ticket for this #2319

@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - B V [production] verified on production enviroment
Projects
None yet
3 participants