Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if file name contains the % symbol #44

Open
yadPe opened this issue Oct 22, 2019 · 0 comments
Open

Error if file name contains the % symbol #44

yadPe opened this issue Oct 22, 2019 · 0 comments
Labels

Comments

@yadPe
Copy link

yadPe commented Oct 22, 2019

When I try to download a file with a name that contains a % symbol It will throw an error and then open the save dialog
image

The file I try to download https://files.beatconnect.io/b/639236+UNISON+SQUARE+GARDEN+-+10%25+roll%2C+10%25+romance+%28TV+Size%29.OuToU.osz

It happens when decodeURIComponent() is called here :

const itemFilename = decodeURIComponent(item.getFilename());

In my case I could fix the issue by simply removing the use of decodeURIComponent() since item.getFilename() already returns a decoded string. But I don't know if it is safe or not to remove this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants