Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to build pa because of missing source file for ninja #202

Open
nightduck opened this issue Feb 28, 2024 · 6 comments
Open

Failure to build pa because of missing source file for ninja #202

nightduck opened this issue Feb 28, 2024 · 6 comments

Comments

@nightduck
Copy link

System

Ubuntu 22.04

Error

...
ninja: Entering directory `out/Default'
ninja: error: '../../third_party/libc++/src/src/algorithm.cpp', needed by 'obj/buildtools/third_party/libc++/libc++/algorithm.o', missing and no known rule to make it

Steps to reproduce

git clone [email protected]:daanx/mimalloc-bench.git
cd mimalloc-bench
./build-bench-env.sh all

This bug occurs on this line in the build script

mimalloc-bench/build-bench-env.sh

Line 528 in a45c31e

autoninja -C out/Default

The setup_packages function ran correctly and ninja-build did get installed
@nightduck
Copy link
Author

Commenting out setup_pa yields an error in setup_tcg, because gawk is not installed

mimalloc-bench/build-bench-env.sh

Line 581 in a45c31e

gawk -i inplace '(f && g) {$0="linkshared = True, )"; f=0; g=0} /This library provides tcmalloc always/{f=1} /alwayslink/{g=1} 1' tcmalloc/BUILD

@nightduck
Copy link
Author

After adding gawk to the list of apt-get install packages, everything else builds correctly

mimalloc-bench/build-bench-env.sh

Lines 417 to 420 in a45c31e

aptinstall "g++ clang lld llvm-dev unzip dos2unix linuxinfo bc libgmp-dev wget \
cmake python3 ruby ninja-build libtool autoconf sed ghostscript time \
curl automake libatomic1 libgflags-dev libsnappy-dev zlib1g-dev libbz2-dev \
liblz4-dev libzstd-dev libreadline-dev"

@jvoisin
Copy link
Collaborator

jvoisin commented Feb 28, 2024

Can you please send a pull-request fixing this? <3

@nightduck
Copy link
Author

I can submit a PR with the gawk fix, but I don't know how to fix the autoninja line failing

@luzhixing12345
Copy link
Contributor

the same issue for me, use no-pa in args flags to skip building pa for now

luzhixing12345 added a commit to luzhixing12345/mimalloc-bench that referenced this issue Feb 29, 2024
@luzhixing12345
add some additional installation dependencies for Ubuntu/Debian
df4f1e4 
pkg-config in building pa with ninja
gawk in building pa with ninja which was mentioned in daanx#202 (comment)
`column` in util-linux to support `cat $devdir/version_*.txt 2>/dev/null | tee $devdir/versions.txt | column -t || true
`
@luzhixing12345 luzhixing12345 mentioned this issue Feb 29, 2024
Merged
jvoisin pushed a commit that referenced this issue Feb 29, 2024
@luzhixing12345
add some additional installation dependencies for Ubuntu/Debian (#203)
4370838 
pkg-config in building pa with ninja
gawk in building pa with ninja which was mentioned in #202 (comment)
`column` in util-linux to support `cat $devdir/version_*.txt 2>/dev/null | tee $devdir/versions.txt | column -t || true
`
@caizixian
Copy link

This was caused by https://github.com/1c3t3a/partition_alloc_builder not pinning the upstream commits, and getting out of sync after this commit chromium/chromium@35902f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jvoisin @caizixian @nightduck @luzhixing12345