Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the speed of the benchmarks #138

Open
jvoisin opened this issue Jun 5, 2022 · 2 comments
Open

Improve the speed of the benchmarks #138

jvoisin opened this issue Jun 5, 2022 · 2 comments

Comments

@jvoisin
Copy link
Collaborator

jvoisin commented Jun 5, 2022

Currently the CI takes around 90min to run: this is a bit excessive. Here is what we could do to reduce a bit this number:

  • Change the parameters for the redis benchmark: SYSMALLOC=1 /__w/mimalloc-bench/mimalloc-bench/extern/redis-6.2.6/src/redis-benchmark -r 1000000 -n 1000000 -q -P 16 lpush a 1 2 3 4 5 lrange a 1 5 takes around a full minute, given that we have ~16 allocators, it adds up rapidly.
  • Lean takes around 1-3 minutes per allocator, and is unmaintained. Shall we try to move to lean4 ?
@mjp41
Copy link
Collaborator

mjp41 commented Jun 7, 2022

So my wondering was about how to split the work up into more parallel tasks.

We could build a Docker image with all the benchmarks, and then we can install that image, and run build and test a subset of the allocators. This would allow us to increase the parallelism, without too much duplication of cost. It would provide a more stable test setup for replication.

I am imagining the allocators change more frequently than the benchmarks for this to make sense. But based on the PRs I think that is correct.

We would still want to test that we can build all the benchmarks, but that could be a separate task, and not have the allocator testing depend on it.

@jvoisin
Copy link
Collaborator Author

jvoisin commented Jun 23, 2022

Unfortunately, I don't think that github actions has the concept of artifacts like gitlab does :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants