Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PHPSecLib encryption method #69

Closed
rlhawk opened this issue Feb 5, 2016 · 3 comments
Closed

Remove PHPSecLib encryption method #69

rlhawk opened this issue Feb 5, 2016 · 3 comments

Comments

@rlhawk
Copy link
Contributor

rlhawk commented Feb 5, 2016

We are not going to be bundling any encryption methods with Encrypt (for more information, see #60), so the PHPSecLib method should be removed from the project.
@svendecabooter
Copy link
Contributor

Is there a use case for turning it into a separate contrib module? Or should it just be removed altogether?
If we keep it around, using it should be discouraged, in favor of a module that uses the Defuse PHP Encryption library.

svendecabooter added a commit to svendecabooter/encrypt that referenced this issue Feb 11, 2016
@svendecabooter
d8-contrib-modules#69 - remove PHPSecLib encryption method
814c81f
@svendecabooter
Copy link
Contributor

I created a project for this module on drupal.org:
https://www.drupal.org/project/encrypt_seclib

I added warnings about using the module, and recommend following best practices (see #79).

nerdstein added a commit that referenced this issue Feb 11, 2016
@nerdstein
Merge pull request #84 from svendecabooter/issue-69
02350d2 
#69 - remove PHPSecLib encryption method
@svendecabooter
Copy link
Contributor

PHPSecLib is removed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svendecabooter @rlhawk