-
Notifications
You must be signed in to change notification settings - Fork 134
Build sometimes working, sometimes not #33
Comments
I'm also seeing this. |
Just reviewed all the code, and everything looks relatively sane. Going to dig deeper. |
I have tried explicitly making an /app/.heroku/vendors dir instead of using Somehow the official Python build pack manages to create the vendors dir
|
I find the exact same thing as @guybowden - pushing an empty Python Django app that doesn't require the geo libraries to get new clean image set up, then pushing the actual app after that and everything works. Subsequent pushes work without a problem, using the cache. |
This line may be to blame https://github.com/heroku/heroku-buildpack-python/blob/master/bin/steps/python#L18 |
Interesting. If that's true, then is the python buildpack not playing nicely with other buildpacks that put libraries into .heroku/vendor, or is the python buildpack allowed to do that? If so, should this buildpack put its libraries somewhere other than .heroku/vendor? |
The real problem here is the first push triggers this behavior, a "stack change". That is likely a bug. |
What sets the default STACK variable in Dokku? According to this https://github.com/heroku/heroku-buildpack-python/blob/master/bin/compile#L148 the |
oh, |
Okay, I believe I have now fixed this. |
@longhotsummer your suggestion was correct :) |
So, the Python buildpack will no longer wipe the contents of It will still do so whenever the stack changes. This almost never happens (once every 2-3 years?). |
Great stuff - thanks for sorting |
Brilliant, thanks @kennethreitz |
I have a cedar-14 app using this buildpack - it apparently builds fine every time, but sometimes the libraries are not present in
/app/.heroku/vendors/lib
This seems to happen if I see these lines in the build log.
A re-deploy fixes the issue.. I don't see those lines above, but the libraries are placed in the lib directory..
The text was updated successfully, but these errors were encountered: