Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process remains running after server close #160

Open
simov opened this issue Oct 10, 2020 · 2 comments
Open

Process remains running after server close #160

simov opened this issue Oct 10, 2020 · 2 comments

Comments

@simov
Copy link

simov commented Oct 10, 2020 •
edited
Loading

Any idea why after server.close the process remains running?

The session middleware seems to be the cause:

app.use(session({store: 'memory'}))

Ok, it's the scheduleGc https://github.com/curveball/session/blob/master/src/memorystore.ts#L97 ...
@evert
Copy link
Member

evert commented Oct 12, 2020

Yes... any further thoughts about this? I don't know if this is easily fixable, but I suppose we could add a function to stop the interval.

@simov
Copy link
Author

simov commented Oct 12, 2020

Definitely opting out will be awesome. Right now I'm monkey-patching setTimeout so that I can close it on server close ..

@evert evert mentioned this issue Feb 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evert @simov