Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-image broken crd generation #160

Closed
AKamyshnikova opened this issue Oct 17, 2024 · 2 comments
Closed

Update ci-image broken crd generation #160

AKamyshnikova opened this issue Oct 17, 2024 · 2 comments

Comments

@AKamyshnikova
Copy link
Collaborator

AKamyshnikova commented Oct 17, 2024

Bug Report

Updating ci image in #156 broke CRD generation:

Currently expr and sed are not function properly giving error:

        crdname=$(basename $crd); \
        end=$(expr $(grep -n ^status $crd|cut -f1 -d:) - 1); \
        cat $(echo v1-crds/$crdname|sed 's/.yaml/_crd.yaml/') > /tmp/$crdname; \
        sed -e '1,/versions/d' -e "1,${end}s/^..//" $crd >> /tmp/$crdname; \
        cp /tmp/$crdname $crd; \
        yq -i e '.spec.versions[0].storage = false' $crd; \
done
expr: syntax error: unexpected argument ‘1’
sed: -e expression #2, char 3: unexpected `,'
expr: syntax error: unexpected argument ‘1’
sed: -e expression #2, char 3: unexpected `,'
expr: syntax error: unexpected argument ‘1’
sed: -e expression #2, char 3: unexpected `,'

Possible solutions:

  • Revert ci-image update (blocks update for higher go versions)
  • Fix CRD updates
@AKamyshnikova
Copy link
Collaborator Author

@cscetbon Do you have time to look on CRD updates?
On first glance I have no idea about it
If not I will revert ci-image update for now

@AKamyshnikova
Copy link
Collaborator Author

Fixed with #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant