Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit.gpgSign causes an error with uploads #253

Open
Douile opened this issue Apr 5, 2021 · 1 comment
Open

commit.gpgSign causes an error with uploads #253

Douile opened this issue Apr 5, 2021 · 1 comment

Comments

@Douile
Copy link

Douile commented Apr 5, 2021

If a user has commit.gpgSign set to true in their global git config check50 will error when trying to upload.

Traceback (most recent call last):
  File "/home/tom/.local/bin/check50", line 33, in <module>
    sys.exit(load_entry_point('check50==3.2.2', 'console_scripts', 'check50')())
  File "/home/tom/.local/lib/python3.9/site-packages/check50/__main__.py", line 336, in main
    commit_hash = lib50.push("check50", internal.slug, internal.CONFIG_LOADER, data={"check50": True})[1]
  File "/home/tom/.local/lib/python3.9/site-packages/lib50/_api.py", line 73, in push
    username, commit_hash = upload(slug, user, tool, data)
  File "/home/tom/.local/lib/python3.9/site-packages/lib50/_api.py", line 354, in upload
    _run(git("commit -m {msg} --allow-empty", msg=commit_message))
  File "/home/tom/.local/lib/python3.9/site-packages/lib50/_api.py", line 704, in _run
    command_output = child.read().strip().replace("\r\n", "\n")
  File "/usr/lib/python3.9/contextlib.py", line 124, in __exit__
    next(self.gen)
  File "/home/tom/.local/lib/python3.9/site-packages/lib50/_api.py", line 697, in _spawn
    raise Error()
lib50._errors.Error
Sorry, something is wrong! check50 ran into an error.
Please let CS50 know by emailing the error above to [email protected].
@Douile
Copy link
Author

Douile commented Apr 7, 2021

^ Should be fixable by just adding --no-gpg-sign to the git args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant