Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkstyle for enforcing coding conventions #219

Open
SKrPl opened this issue Jun 26, 2020 · 1 comment
Open

Add checkstyle for enforcing coding conventions #219

SKrPl opened this issue Jun 26, 2020 · 1 comment
Assignees
@abhijeetviswa
Labels
enhancement

Comments

@SKrPl
Copy link
Member

SKrPl commented Jun 26, 2020

  • Add checkstyle (preferably google's)
  • Add checkstyle checking at the build time
@abhijeetviswa
Copy link
Member

Draft PR #217 aims to fix existing lint errors. It will also add in a CI job to run for every PR thus ensuring the code base doesn't start to smell. Once that PR is merged in, we'll add Checkstyle.

@abhijeetviswa abhijeetviswa added this to the v1.7.0-beta.2 milestone Jun 30, 2020
@abhijeetviswa abhijeetviswa self-assigned this Jun 30, 2020
@abhijeetviswa abhijeetviswa removed this from the v1.7.0-beta.3 milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhijeetviswa abhijeetviswa

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhijeetviswa @SKrPl