-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should validation fail for a mismatch in versions? #47
Comments
I think this is more of a general question and does not only relate to the workflow run crate profile. I wonder if validation profiles should check for their specific version or state a range of versions they are compatible with and then validate if the crate conforms to this range of versions. |
I believe it is reasonable for validation profiles to check their specific version while also supporting the validation of minor updated versions. Specifically, a profile with version At the current stage of the validator’s development, we have only one version per profile. To enable validation, the most recent version of the profile is used even if it is more recent than the requested version. When multiple versions become available, the validator should automatically select version In your specific example, the validation still succeeds because the current constraint on the |
The workflow run crate profile specifically states that is validates against the version 0.5 of the workflow run crate specification.
Right now, the validation still succeeds if a smaller version of the specification is used, i.e. https://w3id.org/ro/wfrun/workflow/0.1.
Is this an intentional choice or should it be considered a bug?
Example
The text was updated successfully, but these errors were encountered: