Consume EC2 Instance panic fix and address perpetual diff #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/ec2/v1beta1/instance.yaml" |
Signed-off-by: Cem Mergenci <[email protected]>
mergenci
force-pushed
the
fix-ec2-instance-panic
branch
from
e3d79dc to
972f8ce
Compare
|
/test-examples="examples/ec2/v1beta1/instance.yaml" |
|
/test-examples="examples/ec2/v1beta2/instance.yaml" |
|
/test-examples="examples/s3/v1beta1/bucket.yaml" |
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
mergenci
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
turkenf
approved these changes
Jan 3, 2025
|
Thank you @mergenci, LGTM 🙌 |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1579. See upbound/terraform-provider-aws#279 for a detailed explanation of the problem and the fix.
I modularized the custom diff code in crossplane-contrib/provider-upjet-azure#816, so that we can simply call this function to ignore empty diffs, as in the example.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Uptest runs: