Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary changes for download-base-artifact #94

Open
mukrop opened this issue Jan 1, 2021 · 1 comment
Open

Necessary changes for download-base-artifact #94

mukrop opened this issue Jan 1, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request libraries Matters and possible bugs in the libaries

Comments

@mukrop
Copy link
Member

mukrop commented Jan 1, 2021

What were the changes necessary to do for download-base-artifact? I see you have a for with a couple of modifications (but origin has since moved on). If there is a functionality we need that is not upstream, what about consolidating your additions and making it a pull request upstream?

@mukrop mukrop added enhancement New feature or request libraries Matters and possible bugs in the libaries labels Jan 1, 2021
@ericvalcik
Copy link
Contributor

I think I fixed the docs-checker. The issue was in the download-base-artifact fork I made, but I believe I've fixed it. I was thinking about adding the functionality to the original repo but wouldn't be better to first write an issue and wait for the maintainer's reaction?

Also, going through with this would take some time I could invest into something else, something maybe more valuable for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request libraries Matters and possible bugs in the libaries
Projects
None yet
Development

No branches or pull requests

2 participants