Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationInfo @type is a JSON String not a JSON array. Data from browser.toJSONString() #146

Open
coderextreme opened this issue Aug 24, 2023 · 7 comments
Labels
confirmed The issue can be reproduced

Comments

@coderextreme
Copy link
Contributor

image

Talk to Don and Vince if you disagree. I will back you, but it may require a few changes...

@coderextreme
Copy link
Contributor Author

It's also possible to accept either in JSON Schema. I will work on that too. I'll broach the discussion.

@create3000
Copy link
Owner

The issue is not whether NavigationInfo.type should be coded differently, but whether MFString values should be coded differently, and that will probably not be the case.

@coderextreme
Copy link
Contributor Author

I agree, but no one wants to discuss it frankly or honestly, they just avoid, avoid, avoid. So I'm looking to supporting both in JSON schema, just for NavigationInfo @type. I agree that all MFStrings should be coded the same.

@coderextreme
Copy link
Contributor Author

JSON schema has been tested, but I haven't changed the schema generation script yet.

@create3000 create3000 added the confirmed The issue can be reproduced label Aug 31, 2023
@coderextreme
Copy link
Contributor Author

If you change MFString implementation, let me know. I am currently assuming that MFStrings are arrays. I have 2 branches of code, one, .json, with NavigationInfo.type as a string. The other, .x3dj as an array. I can merely substitute array for string in the schema if and when the time is right.

@coderextreme
Copy link
Contributor Author

Current X3dtoJson.xslt documentation has NavigatorInfo@type as an array.

@coderextreme
Copy link
Contributor Author

I've got changes to X3dToJson.xslt if you are interested. I will be pushing this through my pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The issue can be reproduced
Projects
None yet
Development

No branches or pull requests

2 participants