Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Columns should only be have as much if landscape and media playing #591

Open
4 of 5 tasks
MarkusTieger opened this issue Dec 23, 2024 · 4 comments
Open
4 of 5 tasks
Labels
bug Something isn't working source question

Comments

@MarkusTieger
Copy link

Issue type

User interface

Device

beyond2lte (compiled myself)

crDroid version

crDroid 11

Exact version / Build date

11.0/2024-12-17

Bug description

You can customize how many rows and columns the QS Tiles should have in the crDroid Settings. If media is playing, it takes half of the space that is used for QS Tiles. Therefore the size of the tile isn't the same as without media playing.

Steps to reproduce

  • Open a video in landscape
  • Open quick settings
  • Notice that the quick tiles have other sizes than before and have to share space with the media controls

Relevant log (logcat/build log)

not required

Screenshots or videos

Current:
Screenshot_20241223-185548_YouTube

Expected:
Screenshot_20241223-185723_YouTube

Solution

Either automatically divide the columns value in the landscape by 2 if a media is playing, or provide a way to configure how many columns should be there if media is playing.

Additional context

No response

Acknowledgements

  • I've checked device is officially supported (for device specific reports and not source related).
  • I'm running latest version available on crdroid.net for this device
  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@MarkusTieger MarkusTieger added bug Something isn't working needs-triage labled for new issues in order to confirm viewed and directed properly labels Dec 23, 2024
@gwolf2u gwolf2u removed the needs-triage labled for new issues in order to confirm viewed and directed properly label Dec 24, 2024
@gwolf2u gwolf2u moved this from Todo to Devices in crDroid 11 Dec 24, 2024
@gwolf2u
Copy link
Member

gwolf2u commented Dec 24, 2024

currently this is how it goes
it used the available space to fit your requirements to how many rows and columns you have defined in crDroid settings
there's no other logic to it
I understand you may need it different when media is played, but is not how the layout thing works

@gwolf2u gwolf2u moved this from Devices to Pending Ideas in crDroid 11 Dec 24, 2024
@MarkusTieger
Copy link
Author

MarkusTieger commented Dec 24, 2024

currently this is how it goes it used the available space to fit your requirements to how many rows and columns you have defined in crDroid settings there's no other logic to it I understand you may need it different when media is played, but is not how the layout thing works

This behaviour with 2 columns in landscape while media is playing works on lineage os (as default, there is no setting for it). crDroid Settings are about adding customizability, not removing them

@gwolf2u
Copy link
Member

gwolf2u commented Dec 24, 2024

We are not LOS
Also we have customization option for rows and columns on qs (can't recall LOS having that)
But while you are right, we are more inclined to customization options, we are also open source
So feel free to check code out and if there's room for improvement, submit pull request for changes

@MarkusTieger
Copy link
Author

submit pull request for changes

Sounds like a way to make us both happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working source question
Projects
Status: Pending Ideas
Development

No branches or pull requests

2 participants