Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: panic in systemtest with v2 binary #23021

Closed
1 task done
technicallyty opened this issue Dec 19, 2024 · 1 comment · Fixed by #23022
Closed
1 task done

[Bug]: panic in systemtest with v2 binary #23021

technicallyty opened this issue Dec 19, 2024 · 1 comment · Fixed by #23022
Labels

Comments

@technicallyty
Copy link
Contributor

technicallyty commented Dec 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

running COSMOS_BUILD_OPTIONS=v2 make test-system yields a panic here:

SetValue(doc, fmt.Sprintf("%s:%d", node.IP, DefaultTelemetryPort+nodeNumber), "telemetry", "address")

looks like telemetry.address is not found in the config.toml.

panic: not found: [telemetry address] [recovered]
        panic: not found: [telemetry address]
goroutine 27565982 [running]:
testing.tRunner.func1.2({0x10194e460, 0x1400247a950})
        /usr/local/go/src/testing/testing.go:1632 +0x1bc
testing.tRunner.func1()
        /usr/local/go/src/testing/testing.go:1635 +0x334
panic({0x10194e460?, 0x1400247a950?})
        /usr/local/go/src/runtime/panic.go:785 +0x124
cosmossdk.io/systemtests.SetValue(0x101524b30?, {0x14001e38780, 0xe}, {0x14002669f00, 0x2, 0x2})
        /Users/tyler/go/pkg/mod/cosmossdk.io/[email protected]/testnet_init.go:198 +0x160
cosmossdk.io/systemtests.(*SystemUnderTest).AddFullnode.func1(0x14002669260)
        /Users/tyler/go/pkg/mod/cosmossdk.io/[email protected]/system.go:741 +0x270
cosmossdk.io/systemtests.EditToml({0x1400209a780?, 0xc?}, 0x140012cda80)
        /Users/tyler/go/pkg/mod/cosmossdk.io/[email protected]/testnet_init.go:181 +0x98
cosmossdk.io/systemtests.(*SystemUnderTest).AddFullnode(0x140000019e0, 0x140022ad380, {0x140012cdf10, 0x1, 0x0?})
        /Users/tyler/go/pkg/mod/cosmossdk.io/[email protected]/system.go:738 +0x7e0
github.com/cosmos/cosmos-sdk/tests/systemtests.TestValidatorDoubleSign(0x140022ad380)
        /Users/tyler/Dev/cosmos/cosmos-sdk/tests/systemtests/fraud_test.go:37 +0x260
testing.tRunner(0x140022ad380, 0x101c73800)
        /usr/local/go/src/testing/testing.go:1690 +0xe4
created by testing.(*T).Run in goroutine 1
        /usr/local/go/src/testing/testing.go:1743 +0x314
FAIL    github.com/cosmos/cosmos-sdk/tests/systemtests  399.508s
FAIL

Cosmos SDK Version

main

How to reproduce?

COSMOS_BUILD_OPTIONS=v2 make test-system

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Dec 19, 2024
@technicallyty technicallyty reopened this Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 🥳 Done to 📋 Backlog in Cosmos-SDK Dec 19, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Dec 19, 2024

I am not able to reproduce.
If I get latest main, run any system tests (like TestExportCmd_WithHeight) it just works.

The last run fails with the expected error (https://github.com/cosmos/cosmos-sdk/actions/runs/12415421254/job/34661752939 / https://github.com/cosmos/cosmos-sdk/actions/runs/12421594041/job/34681645105?pr=23018)

NVM, COSMOS_BUILD_OPTIONS wasn't set correctly on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants