[Bug]: x/staking param validation assumes denom name of 'stake'

[PoisonPhang]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

When the staking params are validated validateKeyRotationFee assumes the denom is 'stake' or whatever DefaultBondDenom is set to. For chains setting this to anything other than 'stake' this will fail.

cosmos-sdk/x/staking/types/params.go

Lines 218 to 232 in 2d04a1a

	func validateKeyRotationFee(i interface{}) error {
	v, ok := i.(sdk.Coin)
	if !ok {
	return fmt.Errorf("invalid parameter type: %T", i)
	}
	if v.IsNil() {
	return fmt.Errorf("cons pubkey rotation fee cannot be nil: %s", v)
	}
	if v.IsLTE(sdk.NewInt64Coin(sdk.DefaultBondDenom, 0)) {
	return fmt.Errorf("cons pubkey rotation fee cannot be negative or zero: %s", v)
	}
	return nil
	}

Cosmos SDK Version

main, v0.52.0-beta.2

How to reproduce?

Validate a genesis where the staking denoms are set to something other than 'stake'

[julienrbrt]

Good catch! Thanks for opening this issue.