Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebHooks support #15

Open
coryodaniel opened this issue Dec 29, 2018 · 2 comments · May be fixed by #203
Open

WebHooks support #15

coryodaniel opened this issue Dec 29, 2018 · 2 comments · May be fixed by #203
Labels
kind:Feature level:Advanced
Milestone
1.1 Release

Comments

@coryodaniel
Copy link
Owner

Add support for Validating and Mutating webhooks.
@coryodaniel
Copy link
Owner Author

#71

@coryodaniel coryodaniel mentioned this issue Oct 9, 2019
Open
@coryodaniel coryodaniel added this to the 0.5 release milestone Oct 23, 2019
@coryodaniel coryodaniel modified the milestones: 0.5 release, 1.0 release Jun 2, 2020
@mruoss
Copy link
Collaborator

mruoss commented Nov 9, 2020 •
edited
Loading

Hey Cory

We needed this feature on our project so I gave it some thoughts and implemented it on my own. Let me quickly share my thoughts first:

  • I think this should be a library on its own. You might need it or not. Or maybe you decide to create separate applications for the operator and the webhook handler.
  • It should be a plug that can be used with Phoenix (or not)
  • As I stated already on Start controllers from Application #82, I would get the information about resources from the YAML file

I have released a first version of bonny_plug today. I used bonny in the name as it is meant as en extension to bonny. Despite that, there are no dependencies to bonny whatsoever. Have a look and let me know what you think.

Cheers,
Michael

@mruoss mruoss modified the milestones: 1.0 release, 1.1 Release Oct 2, 2022
@mruoss mruoss linked a pull request Apr 1, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:Feature level:Advanced
Projects
None yet
Milestone
1.1 Release
Development

Successfully merging a pull request may close this issue.

Support for Admission Control Webhooks coryodaniel/bonny
2 participants
@coryodaniel @mruoss