From b25c980293c0aa4ac38dc12907ba232fc8e3f439 Mon Sep 17 00:00:00 2001 From: Aurele Oules Date: Wed, 3 Jan 2024 01:57:47 +0100 Subject: [PATCH] Show benchmark progress --- .../[owner]/[repo]/pulls/[number]/+page.svelte | 12 +++--------- .../[owner]/[repo]/pulls/[number]/Benchmarks.svelte | 9 +++++++-- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/routes/[owner]/[repo]/pulls/[number]/+page.svelte b/src/routes/[owner]/[repo]/pulls/[number]/+page.svelte index 6004f1b..f735e39 100644 --- a/src/routes/[owner]/[repo]/pulls/[number]/+page.svelte +++ b/src/routes/[owner]/[repo]/pulls/[number]/+page.svelte @@ -174,15 +174,9 @@ {/if}
- {#if report && report.base_report && report.benchmark_status !== "pending"} -
-
- -
-
- {/if} +
+ +
{/if}
diff --git a/src/routes/[owner]/[repo]/pulls/[number]/Benchmarks.svelte b/src/routes/[owner]/[repo]/pulls/[number]/Benchmarks.svelte index 5535aa3..920af63 100644 --- a/src/routes/[owner]/[repo]/pulls/[number]/Benchmarks.svelte +++ b/src/routes/[owner]/[repo]/pulls/[number]/Benchmarks.svelte @@ -5,7 +5,7 @@ export let report: any; function displayBenchNumber(n, showSign = false) { - if(!n) return 0; + if (!n) return 0; return Math.round(n).toLocaleString("en-US", { minimumFractionDigits: 0, maximumFractionDigits: 0, @@ -22,6 +22,7 @@ return r; } +

Benchmarks Beta @@ -42,7 +43,11 @@ Benchmarks are currently being generated, please come back later.

-{:else} +{:else if report.benchmark_status === "failure"} +
+ An error occured while generating the benchmarks. +
+{:else if report.benchmark_status === "success"}