Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapper struct around transitions in getTransitions #136

Open
jpastoor opened this issue Aug 18, 2016 · 1 comment
Open

Remove wrapper struct around transitions in getTransitions #136

jpastoor opened this issue Aug 18, 2016 · 1 comment

Comments

@jpastoor
Copy link
Collaborator

Currently the getTransitions() call returns a struct like:

{
    "expand": "transitions",
    "transitions": [
        {
            "id": "2",
            "name": "Close Issue",

... etc

So what every implementor needs to do is

$transitions_struct = $client->getTransitions();
$transitions = $transitions_struct["transitions"];

See also the code in Api::closeIssue() method.

As far as I can tell by the docs and what ive seen there is no extra information in the expand. Suggestion is to return the ["transitions"] sub array in getTransitions()

@aik099
Copy link
Member

aik099 commented Aug 18, 2016

Agreed. Also tests needs to be added for changed code fragments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants