Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying redirect #1082

Closed
wants to merge 1 commit into from
Closed

Conversation

siosphere
Copy link

When using connect-web SDKs in edge workers, such as Vercel/NextJS, and Cloudflare, the redirect option 'error' is not supported:

ConnectError: [unknown] Invalid redirect value, must be one of "follow" or "manual" ("error" won't be implemented since it does not make sense at the edge; use "manual" and check the response status code).

There currently does not exist a way to overwrite the redirect option to get around this limitation.

This MR adds in the ability to specify redirect as a client option, while keeping the default error

@srikrsna-buf
Copy link
Member

Hey! Thank you for the PR. We want to support edge runtimes around the fetch implementation. We are now actively running tests against cloudflare workers. There is a handler implementation in the tests. That should be good starting point, if you are in immediate need for edge support. We are planning to release companion packages for various edge runtimes, but are waiting on v2 of the package.

@kansson
Copy link

kansson commented Dec 3, 2024

Hey @srikrsna-buf any update to this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants