-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant channel column #1010
Open
soapy1
wants to merge
10
commits into
conda-incubator:main
Choose a base branch
from
soapy1:remove-redundant-channel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
soapy1
force-pushed
the
remove-redundant-channel
branch
6 times, most recently
from
December 6, 2024 01:36
163f1f3
to
f1690bb
Compare
soapy1
force-pushed
the
remove-redundant-channel
branch
from
December 6, 2024 21:05
84b22b1
to
86ffd89
Compare
This information is duplicated by the package relationship. For example, the package table already keeps track of the package channel.
This will: * fix bad db entries * remove channel id from conda_package_build table
soapy1
force-pushed
the
remove-redundant-channel
branch
from
December 16, 2024 23:18
74793f7
to
ebe9c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #994
Description
The primary focus of this pr is to remove the
channel_id
column andchannel
association in theconda_package_build
table. This is redundant information, also available in the associatedpackage
. In order to get channel information from aconda_package_build
users may join theconda_package
table andconda_package_build
table. For example:Things changed in this PR:
channel_id
column in theconda_package_build
tableconda_package_build
to have the correct package associated with each row. See Update conda-package-build causes an integrity error on conda_package_build table #961 for more details about this issuePull request checklist
Additional Info
Part of the migration is to correct some of the conda_package_build entries that have the wrong conda_package associated with them. Since this needs to sort thru all elements of this table, this migration takes a while to run. Users should probably opt to run this migration directly with alembic.