-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [ENH] - Add User
table to database
#975
Draft
peytondmurray
wants to merge
18
commits into
conda-incubator:main
Choose a base branch
from
peytondmurray:930-add-user-to-db
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] [ENH] - Add User
table to database
#975
peytondmurray
wants to merge
18
commits into
conda-incubator:main
from
peytondmurray:930-add-user-to-db
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-store canceled.
|
peytondmurray
added
type: enhancement 💅🏼
area: api 🌐
area: user experience 👩🏻💻
Items impacting the end-user experience
area: workflow-improvements
Issue is affected by upcoming workflow improvements
labels
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: api 🌐
area: user experience 👩🏻💻
Items impacting the end-user experience
area: workflow-improvements
Issue is affected by upcoming workflow improvements
type: enhancement 💅🏼
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930.
Description
This pull request adds a
User
table to the database with the intent of replacing theNamespaceRoleMapping
system for managing user permissions.Role
enum type to replace current role permissioning inconda-store
. Users can have different roles for different environments:NONE
(no access to environment),VIEWER
(can view an environment),EDITOR
(can edit an environment), andADMIN
(administrator for an environment). Integer access levels are also assigned to each of these, with higher values representing greater levels of access; this allows you to do comparisons likeRole.EDITOR < Role.ADMIN
.User
andRoleBinding
tables added to database. EachUser
has zero or more associated entries on theRoleBinding
table which define the level of permissions theUser
has for each environment. When a new user is created, the role bindings passed toconda-store
get translated into entries in theRoleBinding
table, which stores the pattern for each role binding. For example if a user is created with the following role bindings:This will produce two rows in the
RoleBinding
row: one withRoleBinding.role == Role.VIEWER
and another withRoleBinding.role == Role.EDITOR
. The first row matches any environment namedfoo
in any namespace starting withenv
, and the other matches any environment in thehome
namespace.alembic
readme about how to generate database migrations forconda-store
, since there was none.script.py.mako
that would cause new autogenerated migrations to failUser
entries (and associatedRoleBinding
entries are created when the user sends a successful POST to/login/
.schema.AuthenticationToken
has been updated to include auser_name
key for use byconda-store
. No password is stored currently.Note this will require changes for Nebari to pass usernames for the users as part of the token to conda-store.
To do
User
andRoleBinding
tablesuser_name
field toschema.AuthenticationToken
so thatconda-store
can distinguish users. Keycloak will need to do this too!conda_store_server.api.list_environments
Pull request checklist