[ModalBottomSheet] - Paddings passed to Sheet() blocks dismissal of the sheet when clicked

[MFlisar]

Problem

You do already support dismissOnClickOutside in bottom sheets. In your demos you apply styles that add some padding around the content sheet on larger screens. In this case though, it's currently not possible to handle this padding as "background which closes the sheet on click". This means, that I have to write my own scrim composable that handles the touches and closes the sheet if I want to achieve that touching the padding around the content is handled like a touch on the scrim. Not a big thing, but still, as you already support dismissOnClickOutside I think this is an unnecessary restriction.

Suggestion

My suggestion would be to change the API of your scrim and let it wrap its content instead of placing the scrim and the sheet side by side. In this case, the scrim could support content padding and could take care of handling the clicks on the padding as well.

OLD

ModalBottomSheet(
    state = modalSheetState
) {
    Scrim()
    Sheet(
        modifier = if (isCompact) Modifier else Modifier.padding(horizontal = 56.dp)
    ) {
        // Content
    }
}

New

Place the sheet inside the scrim box.

ModalBottomSheet(
    state = modalSheetState
) {
    Scrim(
        modifier = Modifier.let { if (isCompact) it else it.padding(horizontal = 56.dp) }
    ) {
        Sheet(
            modifier = Modifier
        ) {
            // Content
        }
    }
}

[alexstyl]

To clarify, are you saying that spacing on the sides of the sheet currently doesn't dismiss the sheet when clicked?

[MFlisar]

Yes, but just inside the padding from Modifier.padding(horizontal = 56.dp). Because this padding is overlaying the scrim and therefore is handled as click on the sheet although visually its clicking outside the sheet...