-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotated+uploaded pic not considered uploaded by custom picker #5384
Comments
Tried replicating this by changing screen orientation to landscape from portrait at the caption step, it showed correctly for me then after upload is finished in custom picker. Anything I am missing here? |
@srishti-R Do you mean it shows with the Commons logo icon at the bottom of the thumbnail? If not sure would you mind posting a screenshot and precise which pic you uploaded with rotation? Thanks! :-) |
@nicolas-raoul Here's the screen capture. oh did this mean rotating the image as in when editing the image and not the screen orientation? |
Sorry yes, you have to tap |
@nicolas-raoul I tried to attempt this by making LLJTran write the rotated bitmap to the source file instead of creating a separate file. Even when it does, the SHA of the image that is fetched from commons server tells the custom selector that the unrotated image is not the one that was uploaded. Is SHA stored on server dependent on bitmap or the file that was uploaded? If its bitmap, cant do much, since the bitmap was changed and not the file. |
We have a local table containing SHA1 of uploaded files, which we use as a cache. This cache unfortunately disappears when reinstalling the app, but the solution proposed here is a lower-hanging fruit than the solution proposed at #5295, and probably good enough for most users. |
Could you point me to the file where the local cache of SHA1s is present? All I could find out was the code that is checking if the image exists on server using APIs. |
You mean we don't call |
can you assign this issue to me, i think it is related to #5363 issue i just fixed |
[some android sdk that is greater than 28 unable to add image to media store database] [fixed: commons-app#5384]
@mshdabiola Did you get a chance to check my feedback on your pull request at #5569 (review) ? Thanks a lot! :-) |
@mshdabiola I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-) |
Steps:
Edit image
thenRotate
thenSave
).Ideally the app would insert the "already uploaded" info into the local database.
The text was updated successfully, but these errors were encountered: