Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd::journal doesn't return Result #304

Open
cglong opened this issue Oct 26, 2023 · 1 comment
Open

systemd::journal doesn't return Result #304

cglong opened this issue Oct 26, 2023 · 1 comment

Comments

@cglong
Copy link

cglong commented Oct 26, 2023

We were looking at using systemd::journal for sending messages to journald, but noticed all the functions either return a c_int or nothing at all. Given the c_int values aren't well-defined in the docs, we essentially have no way of knowing whether the message was successfully sent or not.

Could these functions be updated to instead return a Result or, less ideally, could the docs be updated to include details on how to interpret the c_ints? Thank you!

@codyps
Copy link
Owner

codyps commented May 2, 2024

I agree that these should return a Result type instead of a plain c_int. Would happily take a patch to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants