fix: ninja birthday not being rendered #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
requested review from
Afonso-santos,
MarioRodrigues10,
ruilopesm and
ruioliveira02
|
AI-Generated Summary: This pull request includes a simple bug fix where the ninja's birthday was not being rendered. It modifies the NinjaJSON controller in the BokkenWeb module, specifically the function that maps a Ninja model to its JSON representation. The fix is the addition of the |
danielsp45
force-pushed
the
dsp/fix-ninja-birthday
branch
from
4b590ef to
0444df5
Compare
MarioRodrigues10
previously approved these changes
Dec 14, 2023
danielsp45
force-pushed
the
dsp/fix-ninja-birthday
branch
2 times, most recently
from
9057b31 to
da1bcfb
Compare
danielsp45
force-pushed
the
dsp/fix-ninja-birthday
branch
from
da1bcfb to
38e0427
Compare
danielsp45
force-pushed
the
dsp/fix-ninja-birthday
branch
from
3b986d7 to
e46c5db
Compare
danielsp45
force-pushed
the
dsp/fix-ninja-birthday
branch
from
34df8dd to
52510f8
Compare
ruilopesm
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.