Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up: Simplify Docker Driver CLEANUP_CONTAINERS config #141

Open
silvin-lubecki opened this issue Oct 7, 2019 · 1 comment
Open

Follow up: Simplify Docker Driver CLEANUP_CONTAINERS config #141

silvin-lubecki opened this issue Oct 7, 2019 · 1 comment

Comments

@silvin-lubecki
Copy link
Contributor

As a follow-up:
The CLEANUP_CONTAINERS config can be simplified if we invert the semantic of the key, with something like KEEP_CONTAINERS.
See #139 (review) .

Also the driver shouldn't print on the standard output without a way to disable it. See #139 (comment) . I guess that with the simplification proposed above this warning could be removed.
@silvin-lubecki silvin-lubecki mentioned this issue Oct 7, 2019
Merged
@jeremyrickard
Copy link
Member

🖖 Thanks @silvin-lubecki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silvin-lubecki @jeremyrickard