-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ApiGateway resources do not match documentation #550
Comments
+1, I need this property so much right now ;) |
Looks great! I quickly went through the docs, and this is what caught my eye, I haven't tested anything: class StageDescription(AWSProperty):
props = {
# ThrottlingRateLimit is defined in the docs as a Number, while others are defined as Integer, so this may need to be a check on float.
"ThrottlingRateLimit": (positive_integer, False),
}
class MethodSetting(AWSProperty):
props = {
# Same remark as above
"ThrottlingRateLimit": (positive_integer, False)
}
class Method(AWSObject):
props = {
# We could add extra validation to authorizationType
# (f you specify the AuthorizerId property, specify CUSTOM for this property.)
"AuthorizationType": (basestring, True),
}
class Integration(AWSProperty):
props = {
"IntegrationHttpMethod": (basestring, False), # Conditional
}
class Model(AWSObject):
props = {
# Schema is a JSON object, so I think this should be (dict, False)
"Schema": (basestring, False)
}
class RestApi(AWSObject):
props = {
# Body is a JSON object, so I think this should be (dict, False)
"Body": (basestring, False),
"FailOnWarnings": (basestring, False), # Should be (bool, False)
"Name": (basestring, False), # Conditional
} |
Since this isn't closed yet, I'm going to add one additional point. From http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-authorizer.html#cfn-apigateway-authorizer-authorizeruri AuthorizerURI is only required for Lambda Authorizers, not for Type='COGNITO_USER_POOLS' |
@aarcro how does bmurtagh@63a7133 and bmurtagh@eaf4a75#diff-4813259e14591fcd34ed4e0213482f00 look to address your AuthorizerURI issue? The second commit just changes |
I'm also taking a stab at the other issues @ikben has pointed out. That work will be done under the same branch followed by a PR. Hoping to start that tomorrow. |
@bmurtagh Looks good to me. |
I don't have time right now to fix it myself, so I'm logging it here.
This is the current code, with in comment what the docs say about required (http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-method.html)
The text was updated successfully, but these errors were encountered: