Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kube-monitoring): Add Pod service discovery #553

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(kube-monitoring): Add Pod service discovery #553

wants to merge 4 commits into from

Conversation

richardtief
Copy link
Member

Fixes #552

@richardtief richardtief requested a review from a team as a code owner December 12, 2024 13:52
ibakshay
ibakshay approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ibakshay ibakshay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

viennaa
viennaa reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@viennaa viennaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resuming from the discussion. Let's discuss inline.

kube-monitoring/charts/values.yaml Outdated Show resolved Hide resolved
kube-monitoring/charts/values.yaml Show resolved Hide resolved
viennaa
viennaa approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@viennaa viennaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibakshay ibakshay ibakshay approved these changes

@viennaa viennaa viennaa approved these changes

@IvoGoman IvoGoman Awaiting requested review from IvoGoman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kube-monitoring] Add service discovery for pods
3 participants
@richardtief @viennaa @ibakshay