Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyze_json.py return ZeroDivisionError in analyzing itg #11

Open
methylpentane opened this issue Jun 2, 2020 · 4 comments
Open

analyze_json.py return ZeroDivisionError in analyzing itg #11

methylpentane opened this issue Jun 2, 2020 · 4 comments

Comments

@methylpentane
Copy link

Hello, chrisdonahue,

I downloaded itg & fraxtil dataset and I suceeded to generate json files but,
when I analyze itg dataset by running ./smd_4_analyze.sh, the python script stop by ZeroDivisionError in line 83. (it has no error in analyzing fraxtil dataset)
I wonder where does the error come from, or is it correct result?

@chrisdonahue
Copy link
Owner

Not sure. Try downloading the exact ITG zips that we used in 2017 from here: https://drive.google.com/drive/folders/1lAQMDtXRk5nMo6acAU8p5G_nhmuMY0XR?usp=sharing

@chrisdonahue
Copy link
Owner

If that doesn't work I can dig a little deeper

@methylpentane
Copy link
Author

methylpentane commented Jun 6, 2020

sorry, it doesn't work, same result.
(diff command return nothing when compare one I downloaded by myself and your drive's.)
I don't have enough coding skill but I'll try to understand situation of the error, thanks

@methylpentane
Copy link
Author

I found cause of zero division of analyze_json.py.

some songs of the ITG/ITG2 don't have EXPERT(Challenge) chart,
and coarse_to_beats is defined as defaultdict(set),
Therefore, len(coarse_to_beats['Challenge']) return 0 without exception at line 81,
but stop at line 83 by zero division.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants