Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔮 PHP 7.2 and 7.3 minimum requirements update timeline #2089

Closed
chrisblakley opened this issue Nov 8, 2020 · 9 comments
Closed

🔮 PHP 7.2 and 7.3 minimum requirements update timeline #2089

chrisblakley opened this issue Nov 8, 2020 · 9 comments
Labels
Backend (Server) Related to the server-side (includes PHP, HTML, etc). Nebula / Documentation Related to the documentation website and not necessarily the Nebula theme itself. Plugin / Library / API For third-party resources such as WordPress plugins, external APIs, and other libraries. 💭 Question / Research Additional research/discussion is needed to answer this question.
Milestone

Comments

@chrisblakley
Copy link
Owner

Currently the minimum PHP version WordPress officially supports is 7.3 and libraries Nebula use are starting to bump their minimum version to 7.2.

Nebula's noted minimum PHP version is 7.0 at the moment, but I know many servers that run Nebula are using versions below 7.2... so bumping up the Nebula minimum would "break" those sites (only if they are using specific features/options).

@chrisblakley chrisblakley added 💭 Question / Research Additional research/discussion is needed to answer this question. Plugin / Library / API For third-party resources such as WordPress plugins, external APIs, and other libraries. Nebula / Documentation Related to the documentation website and not necessarily the Nebula theme itself. Backend (Server) Related to the server-side (includes PHP, HTML, etc). labels Nov 8, 2020
@chrisblakley chrisblakley added this to the 9.0 Cat's Eye milestone Nov 8, 2020
@chrisblakley
Copy link
Owner Author

chrisblakley commented Nov 8, 2020

Might not be as bad as previously thought– here is a list of various PHP versions used by Nebula websites YTD (2020) that are above 1% of "market share":
Screen Shot 2020-11-07 at 7 25 56 PM

Only 2 of these rows are less than 7.2 (and they are 7.1), so maybe in January 2021 I'll bump Nebula up to 7.2 minimum and update libraries.

Related: #2085

@chrisblakley
Copy link
Owner Author

chrisblakley commented Feb 20, 2021

Here is everything over 1% again in the last month (Mid-Jan 2021 to Mid-Feb 2021):
Screen Shot 2021-02-19 at 9 56 12 PM

At this point I think it is safe to bump up to minimum PHP 7.2 and the library benefits that come with it.

Edit: Actually, I do see that 7.0 in the top three. I think what I'll do is update the Readme, and then do the actual bump later.

@chrisblakley chrisblakley pinned this issue Feb 20, 2021
@chrisblakley
Copy link
Owner Author

Note to self: Use the new custom report in Google Analytics to monitor server software version usage (PHP and MySQL).

@chrisblakley
Copy link
Owner Author

chrisblakley commented Feb 21, 2021

When this does get bumped up, do a search for version comparison conditions throughout Nebula for lower versions than the minimum supported.

  • version_compare(phpversion(), '7.2.0', '>=') (/libs/Utilities/Device.php) This library has been removed
  • version_compare(PHP_VERSION, '7.2.0') >= 0 (/libs/Options/Metaboxes.php) This has also been removed

chrisblakley added a commit that referenced this issue Feb 22, 2021
…ent, major Device Detector library update, crossorigin preload fixes

#2118 #2085 #2119 #1610 #2089
@chrisblakley chrisblakley unpinned this issue Mar 16, 2021
@chrisblakley
Copy link
Owner Author

chrisblakley commented Apr 17, 2021

Here's my "from the hip" guess at minimum supported PHP version updates for Nebula (as of April 2021):

  • As of April 2021, minimum supported PHP version is 7.1.
  • 7.2 will probably become the minimum mid-summer 2021 (June/July, After Nebula v9)
  • 7.3 possibly November 2021ish? Maybe into January 2022?
  • 7.4 possibly around June-November 2022 (After Nebula v10)
  • 8.0 sometime in 2023?

This issue is specifically for the 7.2 and 7.3 minimum version updates and will be closed after that. Future min-version updates will use the individual "PHP X.x Upgrade Features/Notes" issues.

Examples:

@chrisblakley chrisblakley changed the title When does Nebula bump up minimum PHP version requirement? When does Nebula bump up minimum PHP version requirement to 7.2? Apr 17, 2021
@chrisblakley chrisblakley changed the title When does Nebula bump up minimum PHP version requirement to 7.2? When does Nebula bump up minimum PHP version requirement (7.2 and 7.3)? Apr 17, 2021
@chrisblakley chrisblakley pinned this issue Apr 17, 2021
@chrisblakley chrisblakley changed the title When does Nebula bump up minimum PHP version requirement (7.2 and 7.3)? PHP 7.2 and 7.3 minimum requirements update timeline Apr 17, 2021
@chrisblakley
Copy link
Owner Author

Here is the data in July 2021 – Mid-August 2021:

Screen Shot 2021-08-19 at 9 51 47 PM

Nothing lower than 7.2 now in the top 30.

@chrisblakley
Copy link
Owner Author

chrisblakley commented Aug 20, 2021

Bumped minimum supported version to PHP 7.2 with next commit.

According to my hip-schedule, we'll eye 7.3 in November 2021, but it seems like it might take longer than that.

Also note that Nebula does not have any checks for version_compare() at this point.

@chrisblakley
Copy link
Owner Author

chrisblakley commented Feb 26, 2022

Here is February 2022 (to date):

Screen Shot 2022-02-25 at 9 51 13 PM

I'm not in any major hurry to update the minimum, but it seems like we could bring it up to 7.3 anytime now.

Updated timeline:

As of Summer 2021ish, minimum supported PHP version is 7.2.
7.3 in April 2022 (in anticipation of Nebula v10)
7.4 at the earliest Fall/Winter 2022, but more likely Spring 2023
8.0 in Fall/Winter 2023?

@chrisblakley chrisblakley modified the milestones: 10.0 Cygnus X, 11.0 TBD May 1, 2022
@chrisblakley
Copy link
Owner Author

chrisblakley commented May 3, 2022

Minimum PHP version is now 7.3.

Closing this issue for the next step: #2147

@chrisblakley chrisblakley unpinned this issue May 3, 2022
@chrisblakley chrisblakley changed the title PHP 7.2 and 7.3 minimum requirements update timeline 🔮 PHP 7.2 and 7.3 minimum requirements update timeline Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend (Server) Related to the server-side (includes PHP, HTML, etc). Nebula / Documentation Related to the documentation website and not necessarily the Nebula theme itself. Plugin / Library / API For third-party resources such as WordPress plugins, external APIs, and other libraries. 💭 Question / Research Additional research/discussion is needed to answer this question.
Projects
None yet
Development

No branches or pull requests

1 participant