Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server disposes clients when it shouldn't #118

Open
Smjert opened this issue Oct 25, 2011 · 0 comments
Open

Server disposes clients when it shouldn't #118

Smjert opened this issue Oct 25, 2011 · 0 comments
Assignees
Milestone

Comments

@Smjert
Copy link
Contributor

Smjert commented Oct 25, 2011

Sometimes the server finds that clients had no activity for 5 secs or more, so it disconnects them.
The problem is that it disconnects them even when they should be still sending packets and the server should answer them back.
This is partially caused by a wrong update on the nextcheckactivity time and some packets missed by the server (the server doesn't notice some of the packets enqueued to be sent).
I fixed it locally, but there's another issue now, with lots of clients the server often disconnects because it didn't received a keep alive packet in the last 60 secs.
This could be related to the fact that i'm running clients and server on the same machine, so clients doesn't have enough cpu time to read all the other packet (mostly chunks packet) and keepalive one, to send an answer back.
Should investigate more.

@ghost ghost assigned Smjert Oct 25, 2011
Smjert added a commit that referenced this issue Oct 28, 2011
Moved the nextActivityCheck after the packet is really sent or received, not after the async call is made.
Some changes in Send_Start code to avoid missing to notice the enqueue of some packets.
#118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant