Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[technical improvement] make self._plugin_overrides a dictionary indexed by func name, for faster access #980

Open
giuseppe-coco opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@giuseppe-coco
Copy link

Is your feature request related to a problem? Please describe.
I am browsing through the cat's code and I found a TODO comment that suggest implementing an improvement: self._plugin_overrides = [] # TODO: make this a dictionary indexed by func name, for faster access
in mad_hatter.plugin module.
So I think I developed the improvement.

Is there a quick way to test it using test module ?

@giuseppe-coco giuseppe-coco added the enhancement New feature or request label Dec 3, 2024
@pieroit
Copy link
Member

pieroit commented Dec 3, 2024

Hi @giuseppe-coco there is a mock_plugin in the test suite that is used to test plugin primitives.
I guess we have no tests yet for the @plugin decorator.

To run them in general, here is a guide:
https://cheshire-cat-ai.github.io/docs/production/administrators/tests/

For sure the improvement is welcome, we'll see how to test it, make the PR if you have pleasure to do it ;)

@giuseppe-coco giuseppe-coco mentioned this issue Dec 3, 2024
1 task
giuseppe-coco pushed a commit to giuseppe-coco/cheshire-cat-ai-core that referenced this issue Dec 3, 2024
@giuseppe-coco giuseppe-coco mentioned this issue Dec 3, 2024
1 task
giuseppe-coco pushed a commit to giuseppe-coco/cheshire-cat-ai-core that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants