Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc issue : Capture a payment require a CaptureRequest #221

Closed
benschumi opened this issue Oct 12, 2023 · 1 comment · Fixed by #225, checkout/checkout-sdk-net#341 or checkout/checkout-sdk-go#90
Assignees
Labels
question Further information is requested

Comments

@benschumi
Copy link

benschumi commented Oct 12, 2023

In the documentation for php, the Capture a payment method indicate that a CaptureRequest is not required for a full capture
https://api-reference.checkout.com/previous/#operation/captureAPayment

try {
     // or, capturePayment("payment_id") for a full capture
    $response = $api->getPaymentsClient()->capturePayment("payment_id", $request);
} catch (CheckoutApiException $e) {

In PHP class Checkout\PaymentsPaymentsClient, the CaptureRequest is not nullable
In previous, the CaptureRequest is nullable.

It's look like just a wrong documentation.
This is the same for Java, Python an PHP

@armando-rodriguez-cko armando-rodriguez-cko self-assigned this Oct 13, 2023
@armando-rodriguez-cko armando-rodriguez-cko added the question Further information is requested label Oct 13, 2023
@armando-rodriguez-cko
Copy link
Contributor

Hello @benschumi, we are checking, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment