Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart for installing on k8s cluster needed #23

Open
fmotrifork opened this issue Feb 22, 2019 · 6 comments
Open

Helm Chart for installing on k8s cluster needed #23

fmotrifork opened this issue Feb 22, 2019 · 6 comments

Comments

@fmotrifork
Copy link
Contributor

There should be a helm chart for installing chartmuseumui with helm.

I propose a helm chart that allows users to specify

  • ChartMuseum API endpoint
  • ChartMuseum Organization
  • Possible auth method and credentials to ChartMuseum
  • Creating Secrets for ChartMuseum UI login

What do you think @jdolitsky & @idobry ?
We could go for a chart to https://github.com/helm/charts/tree/master/incubator ?

@timurkhafizov
Copy link

Actually, I just wrote a very simple Helm chart which has Ingress, Service, and Deployment definitions. Could share it to be used as a basis

@fmotrifork
Copy link
Contributor Author

That would be very useful @timurkhafizov.

@timurkhafizov
Copy link

I'll try to prepare and share it this weekend.
What would be the best place to do so?
I'd propose either deliver it as a separate chart to Helm Incubator, or embed UI definitions to Chartmuseum chart to integrate further.

@fmotrifork
Copy link
Contributor Author

I'm not sure that the current implementation of ChartMuseumUI is feature complete enough to embed in the ChartMuseum chart. It will only be able to show the charts in Chartmuseum for some very specific cases:

  • No auth on Chartmusem at all (basic auth or JWT..)
  • No "depth" on chartmuseum (The current version can handle showing one specific path ( such as "/org1/project2") ) If it is specifically configured to that path.

So i think a seperate chart would be best for now. But an embedded definition would be awesome at a later point.

@jdolitsky
Copy link
Contributor

Hi - @timurkhafizov if you're still willing, the right thing is probably to submit it here: https://github.com/chartmuseum/charts

We are working towards hosting our own helm repo (probably using chartmuseum) for chartmuseum-related charts to submit to the Helm Hub: https://hub.helm.sh/

We can setup CI to push new chart versions there upon merge to master.

@lgg42
Copy link

lgg42 commented Apr 28, 2020

I was about to open a PR for this issue, but I decided to lookup first :-D
My approach was modifying the existing Chart Museum helm chart to add a second deployment / svc / ingress for the ui. With values like:

## Chart Museum UI
ui:
  enabled: true
  image:
    repository: idobry/chartmuseumui
    tag: latest
  env:
    CHART_MUSEUM_URL: "http://chartmuseum:8080"
    # Auth
    BASIC_AUTH_USERS:
      - username: curator
        password: password

IMHO this seems better than having a second helm chart just for this, since the UI part is:

  • a very tiny application
  • already living in the own chart museum repo

What do you guys think of this?

Edit: I just read @timurkhafizov already proposed it 💯 and there's a PR open 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants