Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot4-mono: init at 4.3-stable #867

Merged
merged 1 commit into from
Sep 7, 2024
Merged

godot4-mono: init at 4.3-stable #867

merged 1 commit into from
Sep 7, 2024

Conversation

dr460nf1r3
Copy link
Member

@dr460nf1r3 dr460nf1r3 commented Sep 7, 2024

🐟 What?

Added godot_4-mono, since the package is not available in Nixpkgs yet, nor is the original PR updated. Lets add it until we have a working upstream package.

NixOS/nixpkgs#285941

🎣 Why?

It is a very relevant package for a friend of mine, and me.

🍥 Pending

  • Complain with linter.
  • Build package
  • Test package
  • Fix error "Unable to load .NET runtime, specifically hostfxr."
  • Provide msbuild and dotnet-sdk via Wrapper

@dr460nf1r3 dr460nf1r3 requested a review from a team as a code owner September 7, 2024 08:46
@dr460nf1r3 dr460nf1r3 added the needs-cache Needs to be pushed to Cachix label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This PR has been built and cached! However, it looks like some new failures have been introduced. Please check the logs for more information.

1 packages failed
  • godot4-mono

@github-actions github-actions bot added cached Built & Cached and removed needs-cache Needs to be pushed to Cachix labels Sep 7, 2024
@github-actions github-actions bot removed the cached Built & Cached label Sep 7, 2024
@dr460nf1r3 dr460nf1r3 added the needs-cache Needs to be pushed to Cachix label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This PR has been built and cached! However, it looks like some new failures have been introduced. Please check the logs for more information.

1 packages failed
  • godot_4-mono

@github-actions github-actions bot added cached Built & Cached and removed needs-cache Needs to be pushed to Cachix labels Sep 7, 2024
@github-actions github-actions bot removed the cached Built & Cached label Sep 7, 2024
@dr460nf1r3 dr460nf1r3 added the needs-cache Needs to be pushed to Cachix label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This PR has been built and cached successfully! All changed derivations have built successfully.

@github-actions github-actions bot added cached Built & Cached and removed needs-cache Needs to be pushed to Cachix labels Sep 7, 2024
@github-actions github-actions bot removed the cached Built & Cached label Sep 7, 2024
@dr460nf1r3 dr460nf1r3 added the needs-cache Needs to be pushed to Cachix label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This PR has been built and cached successfully! All changed derivations have built successfully.

@github-actions github-actions bot added cached Built & Cached and removed needs-cache Needs to be pushed to Cachix labels Sep 7, 2024
@dr460nf1r3 dr460nf1r3 self-assigned this Sep 7, 2024
@dr460nf1r3 dr460nf1r3 added the needs-cache Needs to be pushed to Cachix label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This PR has been built and cached successfully! All changed derivations have built successfully.

@github-actions github-actions bot added cached Built & Cached and removed needs-cache Needs to be pushed to Cachix labels Sep 7, 2024
@dr460nf1r3 dr460nf1r3 merged commit 66319c4 into main Sep 7, 2024
4 checks passed
@dr460nf1r3 dr460nf1r3 deleted the godot4-mono branch September 7, 2024 12:00
@CountingBeeps
Copy link

One quick question, I've had issues getting the Godot-mono to run properly from a flake without a full fhs. If you have one, could you send a working flake that uses this one?

@dr460nf1r3
Copy link
Member Author

This is, in fact, a flake providing this package in a working way :) or am I understanding you in a wrong way?

@CountingBeeps
Copy link

Nevermind that, I misunderstood how this worked. I got nyx working, but the build for this package fails.

error: builder for '/nix/store/7nv7r2cafjxcsgh63d533a18xkvw73zr-godot_4-mono-4.3-stable.drv' failed with exit code 1;
       last 10 log lines:
       > /build/source/modules/mono/glue/GodotSharp/GodotSharpEditor/GodotSharpEditor.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json. [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json. [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/GodotSharpEditor/GodotSharpEditor.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json. [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json. [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       >   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotPlugins/GodotPlugins.csproj (in 16.33 sec).
       >   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotSharpEditor/GodotSharpEditor.csproj (in 16.33 sec).
       > /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json. [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/Godot.SourceGenerators.Internal.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json. [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       > /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json. [/build/source/modules/mono/glue/GodotSharp/GodotSharp.sln]
       >   Failed to restore /build/source/modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj (in 33.11 sec).
       For full logs, run 'nix log /nix/store/7nv7r2cafjxcsgh63d533a18xkvw73zr-godot_4-mono-4.3-stable.drv'.
error: 1 dependencies of derivation '/nix/store/l4kajfzg2bfg8awnf07dcipfw0qgxldg-nix-shell-env.drv' failed to build

@dr460nf1r3
Copy link
Member Author

This is interesting - have you set it up the way it is described in the README? You should not have to build the package yourself, it is available via our cache. Best guess I have right now is setting up the flake + it's module first, and then adding the package to your packages. And make sure not to override Nyx's nixpkgs to ensure profiting of the cache.

@dr460nf1r3 dr460nf1r3 restored the godot4-mono branch November 8, 2024 07:15
@dr460nf1r3 dr460nf1r3 deleted the godot4-mono branch November 8, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cached Built & Cached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants